Support variable tag in benchmark #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyuheng55555
requested changes
Nov 14, 2023
| @@ -72,4 +91,22 @@ public static List<List<String>> getClientFiles() { | |||
| public static void setClientFiles(List<List<String>> clientFiles) { | |||
| CLIENT_FILES = clientFiles; | |||
| } | |||
|
|
|||
| public static Map<String, String> getTag(String deviceName) { | |||
There was a problem hiding this comment.
Maybe add some comments to explain it's functionality and the return value.
And, getTags ?
| return res; | ||
| } | ||
|
|
||
| public static Map<String, String> getTag(int deviceId) { |
configuration/conf/config.properties
Outdated
| # 标签值前缀 | ||
| # TAG_VALUE_PREFIX=value_ | ||
|
|
||
| # 每个标签值的取值种数，使用逗号分开，设置个数应与标签名数量相等。例如TAG_NUMBER=2，TAG_VALUE_CARDINALITY=50,10，说明第一个标签名可能有50种值，第二个标签名可能有10种值 |
There was a problem hiding this comment.
Can you further describe what the complete path might look like in this scenario? Would the path be root.test.device.value_10.value_5.sensor?
| private static final String TAG_VALUE_PREFIX = config.getTAG_VALUE_PREFIX(); | ||
| private static final int TAG_NUMBER = config.getTAG_NUMBER(); | ||
| private static final List<Integer> TAG_VALUE_CARDINALITY = config.getTAG_VALUE_CARDINALITY(); | ||
| private static final long[] LEVEL_CARDINALITY = new long[TAG_VALUE_CARDINALITY.size() + 1]; |
There was a problem hiding this comment.
Maybe use List too, to keep consistent with TAG_VALUE_CARDINALITY
liyuheng55555
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old configuration makes all devices have the same tag.
New configuration automatically generates different tags for different devices. Tags will be generated based on the hash value of the deviceName.
For example：